Page 1 of 1

[SUGGESTION] WebGUI enhancement for access_users.php

Posted: 04 Mar 2014 07:06
by crest
During several tests with different user / group permissions I noticed that on the WebGUI page ACCESS | USERS & GROUPS | USERS (access_users.php) under column Group there is currently only the primary group of a user visible. I would find it much more informative to see there all groups a user belongs to.

With a one-liner this can be done, I just changed the line

Code: Select all

<td class="listr"><?=array_search($userv['primarygroup'], $a_group);?>&nbsp;</td>
to

Code: Select all

<td class="listr"><?=array_search($userv['primarygroup'], $a_group); if (is_array($userv['group'])) { for ($i = 0; $i < count($userv['group']); ) { echo ", ".array_search($userv['group'][$i], $a_group); ++$i; } }?>&nbsp;</td>
Now one can see all groups
screen_20140304_080347.png
I would propose to implement this into the next release of N4F.

Regards
crest

Re: [SUGGESTION] WebGUI enhancement for access_users.php

Posted: 11 Apr 2014 16:31
by RedAntz
Thanks crest !

Patch is comitted to SVN : http://sourceforge.net/p/nas4free/code/957/log/?path=

Re: [SUGGESTION] WebGUI enhancement for access_users.php

Posted: 11 Apr 2014 19:52
by crest
RedAntz wrote: Patch is comitted to SVN : http://sourceforge.net/p/nas4free/code/957/log/?path=
Great!
I did another bug ticket / patch for ZFS -> http://sourceforge.net/p/nas4free/bugs/164/, perhaps you can take this too.